Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Do we need to remove these here also: https://ionicframework.com/docs/developing/config#ionicconfig |
Co-authored-by: Brandy Smith <6577830+brandyscarney@users.noreply.github.com>
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
Looking good! A couple of minor things
|
|
||
| ### Legacy Picker | ||
|
|
||
| 1. Remove any usages of the `ion-picker-legacy` and `ion-picker-column-legacy` components. These components have been removed in Ionic 9. Use the [Picker](../api/picker.md#picker-in-modal) component instead. |
There was a problem hiding this comment.
Two things on this line:
First, ion-picker-column-legacy should be ion-picker-legacy-column. The component directory is picker-legacy-column/ and the framework's BREAKING.md uses the correct order, so anyone grepping their templates with this spelling won't find what they're migrating off.
Second, should this note also call out the other removed surface? pickerController, useIonPicker (React), and the PickerOptions / PickerButton / PickerColumn / PickerColumnOption type exports are all gone from the framework packages in #31078. Controller and hook users will hit build errors and the current note only hints at renaming the element. If you do expand this to cover them, the framework's BREAKING.md entry should get the same treatment so the two sides stay in sync.
3 participants
Issue URL: internal
What is the current behavior?
ion-picker-legacyandion-picker-legacy-columnare still being documented. They are components that have been deprecated in v8.What is the new behavior?
Does this introduce a breaking change?
Yes
No
ion-picker-legacyandion-picker-legacy-columnhave been removed from Ionic Framework. The legacy picker component has been replaced with a inline picker component.ion-picker-legacyorIonPickerLegacyshould be changed toion-pickerandIonPicker, respectively.Other information